Skip to content

fix: eliminate 4.3 MB Phosphor icon client chunk #32575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvvmm wants to merge 1 commit into
base: production
Choose a base branch
from
+21 −30
Open

fix: eliminate 4.3 MB Phosphor icon client chunk #32575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 21 additions & 30 deletions src/components/react/PhosphorIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,33 @@
// Renders a Phosphor icon inside a React island. astro-icon's <Icon> is
// Astro-only, so React islands can't use it directly — this resolves icon
// data from the already-installed @iconify-json/ph set at runtime (cheap,
// synchronous, no network fetch) via the same @iconify/utils helpers already
// used for build-time icon resolution in src/pages/directory.astro.
import { getIconData, iconToSVG } from "@iconify/utils";
import phIcons from "@iconify-json/ph/icons.json";
import thumbsUp from "@phosphor-icons/core/regular/thumbs-up.svg?raw";
import thumbsDown from "@phosphor-icons/core/regular/thumbs-down.svg?raw";
import checkCircle from "@phosphor-icons/core/regular/check-circle.svg?raw";
import magnifyingGlass from "@phosphor-icons/core/regular/magnifying-glass.svg?raw";
import x from "@phosphor-icons/core/regular/x.svg?raw";
import checkBold from "@phosphor-icons/core/bold/check-bold.svg?raw";

interface Props {
/** Icon name from the Phosphor set, e.g. "thumbs-up", "magnifying-glass". */
name: string;
className?: string;
}
const icons = {
"thumbs-up": thumbsUp,
"thumbs-down": thumbsDown,
"check-circle": checkCircle,
"magnifying-glass": magnifyingGlass,
x,
"check-bold": checkBold,
};

const cache = new Map<string, { viewBox: string; body: string }>();
type IconName = keyof typeof icons;

function resolve(name: string) {
let entry = cache.get(name);
if (!entry) {
const data = getIconData(phIcons, name);
if (!data) {
throw new Error(`PhosphorIcon: unknown icon "${name}"`);
}
const { attributes, body } = iconToSVG(data);
entry = { viewBox: String(attributes.viewBox), body };
cache.set(name, entry);
}
return entry;
interface Props {
name: IconName;
className?: string;
}

export default function PhosphorIcon({ name, className }: Props) {
const { viewBox, body } = resolve(name);
const svg = icons[name];
return (
<svg
viewBox={viewBox}
fill="currentColor"
<span
aria-hidden
className={className}
dangerouslySetInnerHTML={{ __html: body }}
dangerouslySetInnerHTML={{ __html: svg }}
/>
);
}