PKCS#12 Feature

[haneric21]

Adding option to output a pkcs#12 file
https://github.com/cloudflare/cfssl/wiki/PKCS-%2312-Support-Requirements

Continuation of closed pull request..
#427

[kisom]

LGTM.

[kisom]

Can you update the commit message to be more along the lines of this?

[grittygrease]

This could use a package-level comment.

[grittygrease]

You can output PKCS#12 in base64 format in the API, base64 as output or take a filename in and write to that file.

[haneric21]

@grittygrease, here's an implementation of base64 outputting for CLI. How does this look, am I on the right track?

[grittygrease]

This function returns a string now, so you should return it.

[nathany]

Fyi, @AGWA also implemented PKCS12 writing in the Azure implementation which has since become x/crypto/pkcs12

Azure/go-pkcs12#22

[colemickens]

@nathany From looking at the commit, this PR to cfssl utilizes AGWA's go-pkcs12 fork.

Is this a concern since cfssl already vendors the actual golang.org/x/crypto/pkcs12 library? https://github.com/cloudflare/cfssl/blob/master/Godeps/Godeps.json#L99

[AGWA]

Don't use my go-pkcs12 fork. That repository isn't meant to be stable, and it contains some bugs. I'm working on rebasing it on x/crypto/pkcs12.

[nathany]

Sounds good. Thanks Andrew.

[colemickens]

@AGWA Any update on this? Can you upstream those patches? Looks like it still is rebased for upstream.