fix: respect dry-run during project setup - #166
Merged
Merged
Conversation
commit: |
Contributor
|
LGTM |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 326.6 ms | 3.9 ms | 320.0 ms | 335.3 ms |
| base | 382.6 ms | 4.9 ms | 376.5 ms | 396.5 ms |
Δ (PR vs base): ↓ -55.9 ms (-14.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
Contributor
|
LGTM |
Contributor
|
LGTM |
penalosa
marked this pull request as ready for review
October 2, 2026 11:15
Contributor
|
LGTM |
petebacondarwin
left a comment
Collaborator
There was a problem hiding this comment.
I feel like I am being dumb here and not really understanding the stages of autoconfig and migration (and the difference between the two). So I am marking this review as inconclusive as I don't feel I can make a positive or negative call without more knowledge.
Contributor
|
LGTM |
petebacondarwin
approved these changes
Oct 2, 2026
petebacondarwin
left a comment
Collaborator
There was a problem hiding this comment.
OK I think this is a bit clearer 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dry-runto framework autoconfig and accepted Wrangler config conversion forcf deploy,cf workers versions create, andcf workers triggers deploy.Setup paths
prepareProjectdetects whether cf is already configured. If it is, no setup runs.cf migratecodemod.maybeMigrateWranglerProjectreturnstrueonly after the user accepts and that conversion command completes, including in dry-run mode.configureProjectcalls framework autoconfig to set up the detected project.setupNeeded. The build stops because those setup changes were not applied. For an already configured project, the build still runs and deploy-helpers performs its upload or trigger dry run.--prebuiltskips project preparation and the build.Validation
pnpm checkpnpm test src/__tests__/lib/autoconfig-migration.test.ts src/__tests__/commands/migrate.test.ts src/__tests__/commands/deploy/index.test.ts src/__tests__/commands/triggers-deploy.test.ts(72 passed)pnpm test src/__tests__/commands/deploy/index.test.ts src/__tests__/commands/triggers-deploy.test.ts src/__tests__/commands/versions-upload.test.ts(68 passed)Scope
Configured projects still run their build during a deploy dry run, so build output may change.
cf buildhas no dry-run flag and retains its existing setup behavior.Related to #112.