fix: make cf --version machine-readable - #149
Merged
Merged
Conversation
commit: |
Contributor
|
LGTM! |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 324.6 ms | 6.3 ms | 317.9 ms | 340.9 ms |
| base | 385.6 ms | 3.7 ms | 379.4 ms | 392.8 ms |
Δ (PR vs base): ↓ -61.0 ms (-15.8%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
Contributor
|
LGTM |
penalosa
marked this pull request as ready for review
October 2, 2026 11:41
petebacondarwin
requested changes
Oct 2, 2026
petebacondarwin
left a comment
petebacondarwin
left a comment
Collaborator
There was a problem hiding this comment.
Marginal non-NITs but probably worth requesting changes.
Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>
Contributor
|
LGTM |
Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>
Contributor
|
LGTM |
Contributor
|
LGTM |
petebacondarwin
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cf --versionand-v..cloudflare/directories so repository checks skip local state.Addresses #105, item 2.
Checks
pnpm checkpnpm test src/__tests__/update-check-runtime.test.ts(9 passed)