Fix pnpm installs in cf init Worker projects - #136
Merged
Merged
Conversation
penalosa
marked this pull request as draft
September 30, 2026 19:02
commit: |
Contributor
|
LGTM |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 329.4 ms | 4.3 ms | 323.7 ms | 342.1 ms |
| base | 331.7 ms | 8.1 ms | 324.8 ms | 359.0 ms |
Δ (PR vs base): ↓ -2.3 ms (-0.7%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
penalosa
marked this pull request as ready for review
October 2, 2026 12:22
petebacondarwin
approved these changes
Oct 2, 2026
petebacondarwin
left a comment
Collaborator
There was a problem hiding this comment.
NIT: I'd update the helper to make the tests cleaner when we don't care about the pm in use.
Also, when running cf init in an existing directory, I think we delegate to auto-config. Does this already handle adding in this workspace directory?
petebacondarwin
approved these changes
Oct 2, 2026
penalosa
force-pushed
the
investigate/issue-92
branch
from
October 2, 2026 18:35
a74441d to
e3a9d5f
Compare
penalosa
enabled auto-merge
October 2, 2026 18:35
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-workspace.yamlfor new Worker projects when pnpm is selected, approving theesbuildandworkerdbuild scripts before installation.--no-installso a laterpnpm installworks.cf inittests, and add a patch changeset.This applies the build approval policy from cloudflare/workers-sdk#14193 to the
cf initscaffold.Validation
pnpm test src/__tests__/commands/init.test.ts(27 passed)pnpm --filter cf check:typepnpm check:lintpnpm exec oxfmt --checkon changed filesCloses #92