Open
Conversation
cjpatton
force-pushed
the
cpatton/update-boringssl
branch
from
15f0e51 to
3f0dc33
Compare
This is to include X.509 support for MLDSA. BoringSSL now includes *.in and *.cpp files that re needed for the build.
cjpatton
force-pushed
the
cpatton/update-boringssl
branch
from
3f0dc33 to
aa4d9ae
Compare
cjpatton
changed the title
lukevalenta
approved these changes
Apr 27, 2026
lukevalenta
left a comment
lukevalenta
left a comment
There was a problem hiding this comment.
AI flagged a few minor things, but otherwise LGTM (for what that's worth as someone not too familiar with this crate).
The RPK patch got a lot smaller as it's now mostly provided upstream.
bwesterb
approved these changes
Apr 28, 2026
RPK is now implemented upstream, but we need to add some additional APIs that our bindings expect.
cjpatton
force-pushed
the
cpatton/update-boringssl
branch
from
aa4d9ae to
85c2112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to pick up MLDSA suppport in X.509 in upstream.