Repository navigation
Conversation
Date.parse returns NaN for an unparseable string, so test that directly and return the current time, instead of building a Date and comparing its string form to "Invalid Date". No behavior change. The NaN check is the form blackakula suggested in the review of cloudevents#646. A comment marks the fallback to the current time as deprecated: the spec requires RFC 3339, and v11 will throw a ValidationError instead. Split from cloudevents#646. Signed-off-by: Kevin Mathew Sunny <tokevins@protonmail.com>
new Date(undefined).toISOString() throws a RangeError, so a scenario without a time attribute crashed the step instead of failing the assertion. Compare ISO strings only when both sides have a time, and compare the raw values otherwise. Split from cloudevents#646. Signed-off-by: Kevin Mathew Sunny <tokevins@protonmail.com>
Split from cloudevents#646. Signed-off-by: Kevin Mathew Sunny <tokevins@protonmail.com>
Signed-off-by: Shiva <shiv@shiv.me>
Release-As: 10.1.0 Signed-off-by: Shiva <shiv@shiv.me>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the changes from #646
Everything else in that PR is already on
main: the dependency and typing fixes via #661, the extension header fix via #666.Closes #646