Repository navigation
fix: read binary extension headers regardless of prefix case - #664
Merged
duglin merged 1 commit intoNov 6, 2026
Merged
Conversation
Fixes: cloudevents#566 Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #566
Proposed Changes
ce-extension prefix case-insensitively whenHTTP.toEvent()parses a binary-mode message.Ce-Id) so they are not also added as extensions.Ce-headers.Description
HTTP header names are case-insensitive, and some senders and gateways use canonical header names such as
Ce-Myext.parseBinary()reads the spec attributes from the lowercased headers, but looks for extensions in the original headers with a case-sensitivestartsWith("ce-"). As a result, an extension sent asCe-Myext: valis dropped from the event.The extension name after the prefix keeps its original casing, so the behavior from #420 stays the same:
ce-LUNCHstill becomesevent.LUNCH, andvalidate()still reports it.Because the original headers are now matched case-insensitively, the loop also skips headers that map to spec attributes (for example
Ce-IdorCe-Specversion). Without this check they would show up asIdandSpecversionextensions.Tests:
npm test(228 passing) andnpm run lintpass. The new test fails without the change insrc/message/http/index.ts.