Fix comment parsing without an explicit type present#817
Merged
PierreBtz merged 4 commits intocloudbees-oss:masterfrom May 5, 2026
Merged
Fix comment parsing without an explicit type present#817PierreBtz merged 4 commits intocloudbees-oss:masterfrom
type present#817PierreBtz merged 4 commits intocloudbees-oss:masterfrom
Conversation
aleksei-averchenko-wise
requested review from
PierreBtz and
duemir
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
typefield is not mandatory for comments as per https://developer.zendesk.com/api-reference/ticketing/tickets/ticket_comments/#json-formatNormally, that doesn't matter for parsing because the type is always there - except when dry running a macro: https://developer.zendesk.com/api-reference/ticketing/business-rules/macros/#show-ticket-after-changes
I don't know why, but I did encounter this problem in production after having updated from a very ancient version that didn't use to annotate
Commentwith@JsonTypeInfo.This PR fixes the problem by adding
defaultImpl = Comment.classto the annotation, which makes Jackson use the base class by default when no type is given. I also added unit tests to verify this behaviour.