Repository navigation
Validate endpoint connection info without saving it first - #536
Open
mihaelabalutoiu wants to merge 3 commits into
Open
mihaelabalutoiu wants to merge 3 commits into
mihaelabalutoiu wants to merge 3 commits into
Conversation
Allow `format_keyerror_message` to describe missing attributes of a validation request body. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Move the validation action to `/endpoints/actions` and validate the platform and connection info given in the request body, so an endpoint can be checked before it is saved. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
fix-endpoint-validate-and-save
branch
from
October 1, 2026 09:47
a4ab0a4 to
2626c4b
Compare
Member
Author
|
Note: The integration tests fail with: This is expected: the integration tests install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the endpoint validation API only worked on stored endpoints (
/endpoints/{id}/actions), so we had to save an endpoint before we could check its connection info. Invalid endpoints were persisted when validation failed.This PR implements the following:
format_keyerror_messageto describe missing attributes of a validation request body./endpoints/actionsand validate theplatformandconnection_infogiven in the request body, so an endpoint can be checked before it is saved.unit tests.Related PRs: coriolis-web python-coriolisclient