Skip to content

Refactor implementation for set_dhcp - #534

Merged
Dany9966 merged 1 commit into
cloudbase:mainfrom
fabi200123:fix-set-dhcp
Oct 7, 2026
Merged

Dany9966 merged 1 commit into
cloudbase:mainfrom
fabi200123:fix-set-dhcp

Conversation

@fabi200123

Copy link
Copy Markdown
Contributor

This PR updates the current logic of how set_dhcp is being set and used across. Prior to this PR, the implementation used 2 different set_dhcp options, which caused confusion:

osmorphing_info
├── ...
├── nics_set_dhcp
└── osmorphing_parameters
    ├── retain_user_credentials
    ├── ...
    └── set_dhcp

The one from osmorphing_parameters was not implemented by all providers, while the nics_set_dhcp from osmorphing_info is already on all providers (including those that also added the osmorphing_parameters one.

Now, with this PR I have updated the implementation to drop the osmorphing_parameters.set_dhcp option in favor of osmorphing_info.nics_set_dhcp.

@fabi200123
fabi200123 marked this pull request as ready for review September 28, 2026 10:01
@Dany9966
Dany9966 merged commit 33e46ab into cloudbase:main Oct 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants