Repository navigation
Fix network mapping not following source NIC changes - #942
Open
mihaelabalutoiu wants to merge 2 commits into
Open
mihaelabalutoiu wants to merge 2 commits into
mihaelabalutoiu wants to merge 2 commits into
Conversation
`Reload All Options` re-derived them from the VM info stored on the transfer, which only an execution refreshes, so it never queried the origin endpoint. Also fixes the instance details fallback, unreachable because an empty `dbInstancesDetails` array is truthy. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
`getSelectedNetworks()` rebuilt a mapping for every key of the transfer's `network_map`, so mapping a NIC's new source network added to the map instead of replacing the obsolete entry. Only the mappings of the NICs currently attached to the instances are sent now, unless there are no instance details. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
Edit Transfer modalshowed the NICs recorded by the last execution, so a NIC moved to another network on the source stayed invisible until the transfer ran again — and mapping it then left the obsolete entry behind innetwork_map.This PR implements the following:
Reload All Optionsnow queries the origin endpoint instead of re-deriving the NICs from the VM info stored on the transfer.TransferItemModal