Repository navigation
Allow configuring an additional Syslog listener - #7
Merged
Merged
Conversation
The Syslog worker currently accepts a single listener, using either tcp, udp or unix sockets. Coriolis has been redirecting the container `/dev/log` to an unix socket. However, some services only allow streaming the logs to a tcp or udp Syslog server (e.g. Rabbitmq). To accommodate this scenario, we'll allow configuring an additional listener. Accepting a list of listeners may have been cleaner, however adding a simple "extra listener" setting is much easier and backwards compatible. Besides, it's unlikely that we'll need yet another listener. Co-authored-by: Cursor <cursoragent@cursor.com>
For convenience, we'll add a makefile similar to that used by coriolis-writer. While at it, we'll fix a trivial "go vet" error, complaining about an unbuffered channel.
fabi200123
reviewed
Sep 24, 2026
fabi200123
left a comment
fabi200123
left a comment
There was a problem hiding this comment.
LGTM! Perhaps it might make sense to also add a github action to run the unit-tests
claudiubelu
approved these changes
Sep 24, 2026
We'll use a GH action to run the linter and unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Syslog worker currently accepts a single listener, using either
tcp, udp or unix sockets.
Coriolis has been redirecting the container
/dev/logto an unix socket.However, some services only allow streaming the logs to a tcp or udp Syslog
server (e.g. Rabbitmq).
To accommodate this scenario, we'll allow configuring an additional listener.
Accepting a list of listeners may have been cleaner, however adding
a simple "extra listener" setting is much easier and backwards compatible.
Besides, it's unlikely that we'll need yet another listener.