Skip to content

refactor(admin-roles): migrate from server#2205

Open
shikanime wants to merge 2 commits into
mainfrom
shikanime/push-tlxokqwmmpnv
Open

refactor(admin-roles): migrate from server#2205
shikanime wants to merge 2 commits into
mainfrom
shikanime/push-tlxokqwmmpnv

fix(admin-role): return single role from create() instead of full list

d1ba4de
Select commit
Loading
Failed to load commit list.
cloud-pi-native-sonarqube / SonarQube Code Analysis succeeded Jun 17, 2026 in 46s

Quality Gate success

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

Annotations

Check notice on line 102 in apps/server-nestjs/src/modules/admin-role/admin-role.service.ts

See this annotation in the file changed.

@cloud-pi-native-sonarqube cloud-pi-native-sonarqube / SonarQube Code Analysis

apps/server-nestjs/src/modules/admin-role/admin-role.service.ts#L102 

Unexpected negated condition.

Check notice on line 102 in apps/server-nestjs/src/modules/admin-role/admin-role.service.ts

See this annotation in the file changed.

@cloud-pi-native-sonarqube cloud-pi-native-sonarqube / SonarQube Code Analysis

apps/server-nestjs/src/modules/admin-role/admin-role.service.ts#L102 

Compare with `undefined` directly instead of using `typeof`.

Check notice on line 94 in apps/server-nestjs/src/modules/admin-role/admin-role.service.ts

See this annotation in the file changed.

@cloud-pi-native-sonarqube cloud-pi-native-sonarqube / SonarQube Code Analysis

apps/server-nestjs/src/modules/admin-role/admin-role.service.ts#L94 

Compare with `undefined` directly instead of using `typeof`.
View more details on cloud-pi-native-sonarqube