Use nginx official image for both client and nginx-strangler#2171
Use nginx official image for both client and nginx-strangler#2171StephaneTrebel wants to merge 3 commits into
Conversation
StephaneTrebel
changed the title
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2171.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
StephaneTrebel
force-pushed
the
use-nginx-official-image
branch
2 times, most recently
from
95a4d4a to
0432546
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
force-pushed
the
use-nginx-official-image
branch
3 times, most recently
from
9ffe1e5 to
84b8bf5
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
force-pushed
the
use-nginx-official-image
branch
2 times, most recently
from
14df211 to
e0bea10
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
force-pushed
the
use-nginx-official-image
branch
from
e0bea10 to
aee64fe
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
|
🤖 Hey ! The security scan report for the current pull request is available here. |
3 participants
Issues liées
Issues numéro: #2148
Information intéressante: La substitution des var d'env dans les configurations Nginx est naturellement prise en compte par l'image officielle (cf https://hub.docker.com/_/nginx#using-environment-variables-in-nginx-configuration-new-in-119)
Donc, pas besoin d'
entrypoint.shpournginx-strangler.En revanche, pour
client, on a quand même besoin d'une substitution pour les assets JavaScript car ils sont servi tels quels parnginx, mais se traînent desOPENCDS_ENABLED, etc.On partirait donc sur la piste de conserver la substitution, mais avec un script qui serait exécuté au démarrage de
nginxen le mettant dansdocker-entrypoint.dToDo
clientnginx-stranglerdocker compose) avec des images entarget: dev(integpar ex)docker compose) avec des images entarget: prod(preview)