Skip to content

fix: role always return null #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shikanime merged 1 commit into from
Jun 1, 2026
Merged

fix: role always return null #2164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugins/gitlab/src/members.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Config, Project, UserObject } from '@cpn-console/hooks'
import type { Config, Project, Role, UserObject } from '@cpn-console/hooks'
import type { GitlabProjectApi } from './class.js'
import { AccessLevel } from '@gitbeaker/core'
import {
Expand All @@ -14,7 +14,7 @@ export function getGroupAccessLevelFromProjectRole(project: Project, user: UserO
const projectDeveloperGroupPathSuffixes = (config.gitlab?.projectDeveloperGroupPathSuffix ?? DEFAULT_PROJECT_DEVELOPER_GROUP_PATH_SUFFIX).split(',')
const projectMaintainerGroupPathSuffixes = (config.gitlab?.projectMaintainerGroupPathSuffix ?? DEFAULT_PROJECT_MAINTAINER_GROUP_PATH_SUFFIX).split(',')

const getAccessLevel = (role: any): number | null => {
const getAccessLevel = (role: Role): number | null => {
// TODO: update to AccessLevel.GUEST once we migrated pre-fine grained
// projects members to developer access level via database migrations
if (!role.oidcGroup) return AccessLevel.DEVELOPER
Expand All @@ -24,13 +24,15 @@ export function getGroupAccessLevelFromProjectRole(project: Project, user: UserO
return null
}

// TODO: update to AccessLevel.GUEST once we migrated pre-fine grained
// projects members to developer access level via database migrations
return project.roles.reduce<number | null>((highestAccessLevel, role) => {
if (role.users.some(userRole => userRole.id === user.id)) {
const level = getAccessLevel(role)
if (level && level > (highestAccessLevel ?? 0)) return level
}
return highestAccessLevel
}, null)
}, AccessLevel.DEVELOPER)
}

export function getGroupAccessLevel(project: Project, user: UserObject, config: Config): number | null {
Expand Down