feat/define-app-opr-poc - #2
Open
mdinumonte wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request initializes an OpenProject POC deployment in the opr-poc namespace using Helmfile.
Changes:
- Adds the OpenProject Helm release.
- Configures POC ingress, storage, S3, scaling, monitoring, and resources.
- Adds encrypted S3 credentials and SOPS recipient rules.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Summary and review findings |
|---|---|
helmfile.yaml.gotmpl |
Defines the opr-poc release, but namespace creation is disabled without a Namespace manifest. |
environments/poc/values.yaml |
Configures deployment settings; contains a plaintext admin password, an incorrect temporary storage class key, and incompatible RWO persistence with S3 and multiple replicas. |
environments/poc/secrets.enc.yaml |
Stores encrypted S3 credentials. |
.sops.yaml |
Defines encryption recipients, but omits a recipient already present in the encrypted POC file. |
Suppressed comments (1)
environments/poc/values.yaml:90
- The chart reads
openproject.tmpVolumesStorage(plural), sotmpVolumeStorageis ignored and the ephemeral/tmpand/app/tmpclaims use the chart default (5Gi) instead of the requested 10Gi. Please use the chart's key name.
tmpVolumeStorage: "10Gi"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - key_groups: | ||
| - age: | ||
| - age18hnsrz7twfcecjgzu97gs6pcs5xe3vg3swfwz827833yx2qs6stsjer0aq # Mickael |
Comment on lines
+93
to
+94
| persistence: | ||
| enabled: true |
|
|
||
| useTmpVolumes: true | ||
| tmpVolumeStorage: "10Gi" | ||
| tmpVolumeStorageClassName: "bsu-gp2" |
| hsts: true | ||
|
|
||
| admin_user: | ||
| password: "admin" |
| chart: openproject/openproject | ||
| version: 13.10.2 | ||
| installed: true | ||
| createNamespace: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at initializing the argocd app responsible for deploying OpenProject in its own namespace.