Scroll to top#220
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 433e8378cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| .frbl-scroll-top--left { | ||
| left: 24px; |
There was a problem hiding this comment.
When Scroll to Top is configured as “Bottom left” and the existing Back Button feature is also enabled, this puts both controls at the same fixed bottom: 24px; left: 24px position; I checked the existing back button styles in assets/back-button/frontblocks-back-button.css, which use those same offsets. In that setup the later scroll-top button can cover the back button, so one of the two floating controls needs an offset or the left option should account for the back button.
Useful? React with 👍 / 👎.
| mediaFrame = wp.media({ | ||
| title: '" . esc_js( __( 'Select Icon', 'frontblocks' ) ) . "', | ||
| button: { text: '" . esc_js( __( 'Use this image', 'frontblocks' ) ) . "' }, | ||
| multiple: false | ||
| }); |
There was a problem hiding this comment.
The media frame is opened without a library type filter, so an admin can select a PDF, video, or other attachment even though the saved URL is rendered later as an <img> for the button icon. If a non-image attachment is chosen, the frontend icon breaks; add an image-only media filter for this picker.
Useful? React with 👍 / 👎.
2 participants
Fixes #219