Repository navigation
Fix storage failure tests under jsdom's Storage semantics - #3
Merged
Merged
Conversation
The persistence-failure tests replaced localStorage.setItem by direct
assignment. jsdom's Storage is an exotic object: assigning to a property
stores it as an item instead of overriding the method, so the throwing
stub never ran and both tests asserted against a save path that had
silently succeeded ("expected 'saved' to be 'error'").
Stub via vi.spyOn(Storage.prototype, ...) instead, which intercepts the
method regardless of how the environment implements the instance, and
restore with mockRestore() so later assertions see real storage.
This was referenced Aug 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Both persistence-failure tests in
src/store.test.tsfail on a clean checkout:Why
The tests replaced
localStorage.setItemby direct assignment. jsdom'sStorageis an exotic object: assigning to a property stores it as an item instead of overriding the method, so the throwing stub never ran — the store saved successfully and the assertions comparing against the failure path broke.How
Stub with
vi.spyOn(Storage.prototype, "setItem" / "getItem")instead, which intercepts the method regardless of how the environment implements the instance, andmockRestore()afterwards so later assertions in the same test see real storage. No production code touched.Verify