clay: fail fast with a clear WSL pointer on native Windows - #16
Open
jad030207 wants to merge 1 commit into
Open
Conversation
bin/clay's OS detection now recognizes Git Bash/MSYS/Cygwin's uname -s output (MINGW64_NT-*, MINGW32_NT-*, MSYS_NT-*, CYGWIN_NT-*), which previously fell through to a generic 'unsupported OS: $os' error. It now fails fast pointing users at WSL as the supported path, using the same validation_error category/exit code as the existing OS/arch checks. Addresses the "at minimum a clear error message" fallback requested in clay-run#9. No Windows CLI binary is published (checksums.txt only lists darwin-arm64, darwin-x64, linux-arm64, linux-x64), and building one is a change to the clay CLI's own build/release pipeline, not this plugin repo, so this does not add native Windows support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/clay's OS detection now recognizes Git Bash/MSYS/Cygwin's uname -s output (MINGW64_NT-, MINGW32_NT-, MSYS_NT-, CYGWIN_NT-), which previously fell through to a generic 'unsupported OS: $os' error. It now fails fast pointing users at WSL as the supported path, using the same validation_error category/exit code as the existing OS/arch checks.
Addresses the "at minimum a clear error message" fallback requested in #9. No Windows CLI binary is published (checksums.txt only lists darwin-arm64, darwin-x64, linux-arm64, linux-x64), and building one is a change to the clay CLI's own build/release pipeline, not this plugin repo, so this does not add native Windows support.