Repository navigation
Footage: a file too big for the connection comes by its shared link - #59
Merged
Merged
Conversation
A file the Drive connection couldn't download (too big for its temporary storage) was copied inside Google into the connected account, shared with the link, and imported from the copy. For big files that import failed: Drive answers a header check on a fresh copy with an empty HTML page (seen for 8 minutes and more, on every copy tried) while the file itself downloads, and the video host, which checks first, refused the download as an invalid or inconsistent response. 11 of the 15 clips that took that route failed this way, most of them interviews. Such a file now comes by the original's shared link, which answers the same check with the video and its size, with the existing waits when Drive limits it. No copy is made any more; copies an earlier version made are still deleted once their import is over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while retrying a real shoot's failed interviews: 11 of the 15 clips that ever took the copy route failed with Stream's "The source returned an invalid or inconsistent response while downloading the video" (7 Day 2 interviews, 2 Day 3 interviews, 2 static cams).
Evidence (curl against Drive's download endpoint):
HEAD→200 video/mp4, content-length: 15108478104;Range: 0-0→206 bytes 0-0/15108478104.HEAD→200 text/html, content-length: 0, every check for 8+ minutes; rangedGETs → 206 with the right bytes. Same result for copies of a 9.66 GB file that once imported and one that didn't.Change:
startImport: connection download first; when it can't hand the file over,link_only = 2and the original's shared link (existing probe, quota page detection and waits). The copy step is gone (driveCopyForImport,driveCreateFolder, the copy folder setting,DriveSource.copy).link_only = 0, was< 2).copy_id) are still deleted once their import is over or with the project.e2e 12: the too-big file imports from the original's shared link in the same delivery, no copy/permission/folder action is ever called, and a leftover copy is deleted after one refused delete.
Checks: tsc, 162 unit tests, end to end ALL OK, build.