Repository navigation
test(prompt-invariants): split random interleavings into 10 tests with per-test fake DOM (lr-248bff) - #484
Merged
clagentic-merger[bot] merged 1 commit intoOct 23, 2026
Conversation
…h per-test fake DOM (lr-248bff) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
PEACHES — clean (0 finding(s), 1 dropped) Dropped candidates (1):
|
|
BOBBIE — clean (0 finding(s)) |
Contributor
|
Merged via clagentic-loadout v0.2.0
|
clagentic-merger
Bot
deleted the
chore/lr-248bff-split-random-interleavings
branch
October 23, 2026 16:41
Contributor
|
This issue has been resolved in version 1.11.0-beta.2. To update, run: |
Contributor
|
This issue has been resolved in version 1.11.0. To update, run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-only.
test/prompt-invariants.test.js: the single 150-seed random-interleavings test is split into 10 tests of 15 seeds each (seed values 1..150 unchanged, same mulberry32 PRNG, STEPS 40 unchanged). No product code touched.Why
The one test sat at or over its 300 s timeout in a full local run, failing by wall time, and its still-running loop then failed the next test.
Changes
seeds 1 to 15...seeds 136 to 150, each with a 120 s timeout (measured max 68 s under full npm test, 35 s alone).describeafterhook asserts every ending kind > 0 and dead == 0 over all 150 seeds, once all 10 parts completed. This is the same assertion over the same union of runs as before, so it is equivalent (a per-slice assertion would be stricter than the original and could fail on a rare ending such as restart). If a part failed or timed out it is already reported and the partial tally is not judged.freshDom) per random part and per scenario test, replacing the file-levelbefore.randomRunnow stops ont.signal.aborted(node:test aborts it on timeout), so a timed-out part stops mutating process env, the module cache and the DOM instead of running on under the next test; that leak, not the DOM object alone, is what failed the sub-agent test.Evidence
Forced-timeout check (part timeout temporarily 2 s, then reverted): all 10 parts fail by timeout, every later test including
a sub-agentsrequestsurvivesitsparents turn resultpasses. That test also passes alone (288 ms,--test-name-pattern).File alone (10 parts): 3.2, 12.6, 30.6, 33.1, 35.4, 30.3, 31.3, 28.7, 29.4, 34.9 s (suite 269.6 s, spec has no single test over 36 s).
Three consecutive full
npm testruns on this host (part times in s, parts 1..10):web-UI shutdown_server reaches the announcer(ENOTEMPTY, lr-c3e80a flake). prompt-invariants absent.web-UI shutdown_server reaches the announcer(ENOTEMPTY),codex: a loop iteration is recorded as the loop(ENOTEMPTY) (both lr-c3e80a),a gatekeeper session still pending at the timeout is cancelled...(identity dir, lr-7da984 late-settle). prompt-invariants absent.Profile has no test block (
clagentic-loadout test runexits 72), sonpm testis the admitted command; no loadout run ids.TASK: lr-248bff
class sweep: other 300 s+ single loops in test/ not examined (out of scope, test-only fix for this file).
🤖 Generated with Claude Code