Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary validation PR for the processing-instruction canonicalization security fix. The final upstream review PR is node-saml#641.
Red proof: test-only commit 10aef05, Test Status run 37001064689 (Node 20: 516 passing, 8 expected failures). Four
SignedXml.checkSignature()cases accepted text replaced by a PI; four canonicalization output checks failed on empty-data PI.Green proof: fix commit e3e9c08, Test Status run 37002038196 (Node 16, 18, 20, 22, 24, latest and lint successful), CodeQL run 37002038200 successful.
npm ciran TypeScript compilation throughprepare.