Conversation
added 11 commits
September 8, 2026 13:53
…ecture and config
… tests/fm-backend-herdr-focus-flash-e2e.test.sh Part C, a file untouched by this PR, but it is a real flaky test rather than an external/infra failure, so I made it deterministic. Root cause: on a below-floor herdr release (CI runs 0.7.4, steal_live=1), Part C required an external polling sampler to catch at least one wrong-focus sample inside the window between the plain explicit close and the adapter's restore backstop. That window is a couple of CLI round-trips wide while each sampler iteration costs two lab calls, so catching a sample is pure timing: CI caught zero and failed ("observed no wrong-focus sample at all, so the sampler proved nothing"); the identical code caught 4 samples locally. Fix: Part C now reads the same fact from deterministic in-band evidence it already collects, the adapter call log. fm_backend_herdr_projection_focus_restore issues `tab focus` exactly when its own post-close snapshot differs from the pre-operation snapshot, so on a defective release `^tab focus` must appear (wrong-focus window existed and the exact-tab backstop closed it, alongside the pre-existing C_AFTER = C_BEFORE outcome assertion), and on a focus-preserving release it must not appear. This mirrors the call-log assertion Part B already makes, so the racy Part C sampler (subshell, ready/active/stop files, sample tallies) was deleted rather than tuned. Part B's sampler and all production code are untouched; no new machinery added. Verified locally with real herdr 0.7.4 (temporarily started a headless default session for the lab tripwire, then `herdr server stop`; default session back to not-running, other sessions untouched): the test passed 3 consecutive runs with exit 0, and bin/fm-lint.sh (ShellCheck 0.11.0 + actionlint) is clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Le capitaine demande d enchaîner encore deux lots regroupés et précise : « là tu utilises gpt 5.6 ».
Ce lot corrige les contrats générés pour deux chemins de livraison :
Ce brief est en français, ta livraison ne l est pas.
What Changed
Risk Assessment
Testing
Diff inspection, targeted executable tests, and generated-output checks passed. Captured worker contracts and recent-to-quiet watcher behavior demonstrate the requested interfaces; no live pipeline or forge delivery was attempted. No UI surface changed.
Evidence: Generated no-mistakes brief
Source: Generated no-mistakes brief
Evidence: Generated direct-PR brief
Source: Generated direct-PR brief
Evidence: Delivered no-mistakes promotion contract
Source: Delivered no-mistakes promotion contract
Evidence: Delivered direct-PR promotion contract
Source: Delivered direct-PR promotion contract
Evidence: Recent activity defers; quiet validation escalates
Source: Recent activity defers; quiet validation escalates
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
Inspectedgit diff d42016a cd3f4beto identify changed behavior.Executed fm-brief selectors:test_ship_modes_generate_clean_briefs,test_active_no_mistakes_validation_cannot_be_deferred,test_direct_pr_requires_forge_proof_and_diagnosis,test_ask_user_escalation_format.Executed fm-task-delivery selector:test_promotion_delivers_the_real_definition_of_done.Executed fm-crew-state selectors:test_active_run_reports_its_own_activity_recency,test_daemon_claim_over_live_run_reads_run_alive,test_socket_refusal_over_stale_fixing_run_reports_blocked.Executed fm-watch-triage selectors:test_busy_turn_bound_defers_only_while_the_run_reports_recent_activity,test_busy_pane_default_turn_age_bound_is_3600s,test_busy_pane_repeated_escalation_reaches_demand_deep_inspection.Captured generated briefs, delivered promotion payloads, and watcher logs; inspected emitted contracts and escalation evidence.Removed temporary selector scripts and verifiedgit status --shortwas empty.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.