Skip to content

fix(arcup): accept a checksum file with no trailing newline #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erkancamli wants to merge 4 commits into from
Closed

fix(arcup): accept a checksum file with no trailing newline #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26d2f1f
fix(arcup): accept a checksum file with no trailing newline
erkancamli Sep 13, 2026
00c4319
fix(arcup): accept a checksum file with no trailing newline
erkancamli Sep 13, 2026
936bff2
chore(arcup): bump ARCUP_INSTALLER_VERSION to 0.2.1
erkancamli Sep 16, 2026
e486e59
test(arcup): assert the error message, not just a non-zero exit
erkancamli Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions arcup/arcup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -euo pipefail

# NOTE: if you make modifications to this script, please increment the version number.
# WARNING: the SemVer pattern: major.minor.patch must be followed as we use it to determine if the script is up to date.
ARCUP_INSTALLER_VERSION="0.2.0"
ARCUP_INSTALLER_VERSION="0.2.1"

REPO="${ARC_REPO:-circlefin/arc-node}"
if [[ -n "${ARC_REPO:-}" ]] && [[ ! "$ARC_REPO" =~ ^[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+$ ]]; then
Expand Down Expand Up @@ -656,7 +656,16 @@ verify_checksum_file() {
local archive_name="$3"
local expected_checksum expected_name actual_checksum

if ! read -r expected_checksum expected_name < "$checksum_path"; then
if [[ ! -r "$checksum_path" ]]; then
error "Checksum file is missing or unreadable: $checksum_path"
fi

# `read` reports failure at EOF even when it populated the variables, which is
# what happens when the checksum file has no trailing newline. Inspect the parsed
# value rather than the exit status so a valid single-line file is still accepted.
read -r expected_checksum expected_name < "$checksum_path" || true

if [[ -z "$expected_checksum" ]]; then
error "Checksum file is empty: $checksum_path"
fi

Expand Down
40 changes: 40 additions & 0 deletions arcup/test_arcup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,25 @@ expect_fail() {
pass "$name"
}

# Like expect_fail, but also pins the message. Without this a test only proves the
# call exited non-zero, which it already did before the fix for the wrong reason.
expect_fail_message() {
local name="$1"
local expected="$2"
shift 2

if ( "$@" ) >"$TEST_TMP/expect_fail.out" 2>&1; then
cat "$TEST_TMP/expect_fail.out" >&2
fail "$name"
fi
if ! grep -qF "$expected" "$TEST_TMP/expect_fail.out"; then
printf 'expected message: %s\nactual output:\n' "$expected" >&2
cat "$TEST_TMP/expect_fail.out" >&2
fail "$name"
fi
pass "$name"
}

test_version_normalization() {
assert_eq "v1.2.3" "$(normalize_version "1.2.3")" "normalizes missing v prefix"
assert_eq "v1.2.3" "$(normalize_version "v1.2.3")" "keeps v-prefixed version"
Expand Down Expand Up @@ -119,6 +138,27 @@ test_checksum_validation() {

printf '%s other-asset.tar.gz\n' "$checksum" > "$checksum_file"
expect_fail "checksum filename mismatch fails" verify_checksum_file "$archive" "$checksum_file" "$archive_name"

# A checksum file with no trailing newline is still a valid single-line file;
# `read` reports EOF for it even though the fields parsed fine.
printf '%s %s' "$checksum" "$archive_name" > "$checksum_file"
verify_checksum_file "$archive" "$checksum_file" "$archive_name"
pass "checksum file without trailing newline passes"

printf '%s' "$checksum" > "$checksum_file"
verify_checksum_file "$archive" "$checksum_file" "$archive_name"
pass "bare checksum without filename or newline passes"

: > "$checksum_file"
expect_fail_message "empty checksum file fails" "Checksum file is empty" \
verify_checksum_file "$archive" "$checksum_file" "$archive_name"

printf '\n' > "$checksum_file"
expect_fail_message "blank-line checksum file fails" "Checksum file is empty" \
verify_checksum_file "$archive" "$checksum_file" "$archive_name"

expect_fail_message "missing checksum file fails" "Checksum file is missing or unreadable" \
verify_checksum_file "$archive" "$TEST_TMP/absent.sha256" "$archive_name"
}

test_download_error_lists_assets() {
Expand Down
Loading