Skip to content

docs(precompiles): document nextBaseFee in the gas-values slot layout - #398

Closed
Ruzzgar wants to merge 1 commit into
circlefin:mainfrom
Ruzzgar:docs/system-accounting-nextbasefee
Closed

Ruzzgar wants to merge 1 commit into
circlefin:mainfrom
Ruzzgar:docs/system-accounting-nextbasefee

Conversation

@Ruzzgar

@Ruzzgar Ruzzgar commented Sep 13, 2026

Copy link
Copy Markdown

pack_gas_values_for_storage packs three fields into the slot:

slot[24..32] = gasUsed;
slot[16..24] = gasUsedSmoothed;
slot[8..16]  = nextBaseFee;

but the layout comment above it lists only the first two. The comment predates the nextBaseFee field (the Zero3 test helper, which really does pack two fields, carries the same text). Add the missing line.

Comment only — unpack_gas_values_from_storage already reads [8..16] and the existing round-trip test covers nextBaseFee.

…lot layout

pack_gas_values_for_storage writes nextBaseFee to bytes [8..16], but the layout
comment lists only gasUsedSmoothed and gasUsed. The comment predates the
nextBaseFee field. Add the missing line.
@ZhiyuCircle

Copy link
Copy Markdown
Contributor

Hi @Ruzzgar,

Thank you for your interest in contributing to Arc Node, and apologies for the delay in getting back to this PR.

We're closing out the pull request backlog that predates our current contribution policy. This PR is being closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format Closes: #XXX, and the author must be assigned to that issue before the PR is opened.

This is not a judgement on the change itself. If you'd still like to land it:

  1. Open an issue describing the problem, or find the existing one
  2. Comment on the issue requesting assignment, and wait for maintainer approval
  3. Open a fresh PR once you have been assigned

Please see CONTRIBUTING.md for details. Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants