chore: release v0.8.4 - #64
Conversation
freshtonic
left a comment
There was a problem hiding this comment.
Automated review of the first release-plz PR (observation phase, CIP-4132).
Summary: The generated output is correct and consistent. The version changes from 0.8.3 to 0.8.4 in Cargo.toml and Cargo.lock. The semver check reports API-compatible changes. The PR triggered test.yml through the GitHub App token, and all four checks pass. The new changelog section is below ## Unreleased, and that agrees with the Keep a Changelog format of the file. For step 4 of docs/research/release-plz.md, this PR is good evidence that the release-PR job operates correctly.
Recommendation: do not merge this PR yet.
-
No publish job exists.
.github/workflows/release-plz.ymlhas only therelease-prjob. If you merge this PR now,mainwill declare 0.8.4, but nothing publishes 0.8.4 to crates.io and nothing creates a0.8.4tag. That is the same "declared but not released" condition that CIP-4131 had to reconcile for 0.8.3. Also, withrelease_always = false, the release job publishes only on a commit that merges a release PR. If you add the release job after this merge, it will possibly not publish 0.8.4 without a manual step. Keep this PR open (release-plz updates it on each push tomain), or close it. Merge a release PR only after the Trusted Publishing release job is in place (rollout step 5). -
The release has no crate-facing change. Both changelog entries are internal (a CI workflow and a research document). See the inline comment.
-
Compare link. The new heading links to
compare/0.8.3...0.8.4. This link operates only if a0.8.3tag is onorigin. My local clone has no0.8.3tag (the latest local tag is0.8.2). Make sure that the tag exists before the first automated release. If it does not exist, the link and the release-plz tag history will be incorrect.
There are no blocking problems in the diff itself.
31aa542 to
5c7daaa
Compare
freshtonic
left a comment
There was a problem hiding this comment.
Automated re-review of head 5c7daaa. The earlier review was on 31aa542.
Changes since the earlier review: release-plz rebased the PR on main after #68. The diff now has a third changelog entry, "(agents) track issues in GitHub instead of Linear". That commit (e90a5b0) changes only AGENTS.md, docs/agents/*, and docs/research/release-plz.md. It does not change the published crate. The version change (0.8.3 to 0.8.4 in Cargo.toml and Cargo.lock) is correct, and all four checks pass on this head.
The earlier findings are still applicable:
- No publish job.
.github/workflows/release-plz.ymlonmainstill has only therelease-prjob. Do not merge this PR until the Trusted Publishing release job is in place (rollout step 5). If you merge it now,maindeclares 0.8.4, but nothing publishes it or tags it. - Internal-only release. All three entries are docs or CI changes. The open inline thread on
CHANGELOG.mdgives possiblerelease-plz.tomlsettings to skip these commits. - The
0.8.3tag is not on GitHub. I examined the remote this time, not only a local clone. The GitHub tags API shows0.8.2as the latest tag, andgit/ref/tags/0.8.3returns 404. Thus thecompare/0.8.3...0.8.4link in the new heading does not operate. Also, release-plz uses tags to find the previous release. Push a0.8.3tag on the 0.8.3 release commit before you enable the release job.
There are no blocking problems in the diff itself.
5c7daaa to
18cf294
Compare
freshtonic
left a comment
There was a problem hiding this comment.
Automated re-review of head 18cf294. The earlier review was on 5c7daaa.
Recommendation: approve. The earlier blockers are fixed:
- Publish job: fixed. On
main(5476aa3, #65),.github/workflows/release-plz.ymlhas arelease-gatejob and areleasejob. Thereleasejob runs only when the push merges a release PR fromcipherstash-envelopers-release-plz[bot]on arelease-plz-*branch. It uses Trusted Publishing (id-token: write) and thereleaseenvironment. Thereleaseenvironment hasrequired_reviewersandbranch_policyprotection rules. Thus a merge of this PR starts a publish of 0.8.4, and a reviewer must approve the deployment first. 0.8.3tag: fixed.refs/tags/0.8.3is on GitHub. It is an annotated tag on60a9151, which agrees with the.cargo_vcs_info.jsonsha of the published crate. Thecompare/0.8.3...0.8.4link now operates.- Internal-only release: accepted. This release is the verification run for the release job. The commit filter is a follow-up item. I resolved the thread.
The diff: The version changes from 0.8.3 to 0.8.4 in Cargo.toml and Cargo.lock, and there are no other manifest changes. The semver check reports API-compatible changes. The new section is below ## Unreleased. All four checks pass on this head.
Non-blocking note: The changelog does not include e90a5b0 ("docs(agents): track issues in GitHub instead of Linear") or the merge of #68. The earlier head included them. The two commits change only agent docs, so this has no effect on users of the crate. If you want a complete changelog, add the line manually before merge.
After the merge, make sure that the release job publishes 0.8.4 to crates.io and pushes a 0.8.4 tag and GitHub release.
🤖 New release
envelopers: 0.8.3 -> 0.8.4 (✓ API compatible changes)Changelog
This PR was generated with release-plz.