ci: add BDShot compile test + standardize workflow shape#2
Merged
Merged
Conversation
Goal 5 (BDShot in CI): adds tests/bdshot_compile_test.cpp that exercises
BDShot.cpp the way the README documents — `#include <AVR++/BDShot.cpp>`
plus an explicit `template class` instantiation. BDShotConfig::Debug::Pin
defaults to a dummy IOpin (Pin=8), so no stub config is required.
Previous CI skip-note ("needs user config") was wrong — the actual reason
BDShot.cpp can't compile standalone is that it's not a translation unit,
it's an include-only .cpp; comment fixed.
Goal 6 (workflow standardization): adds `make` to the apt-install line
and `make --version` to the toolchain-versions step so AVR matches the
other firmware repos' CI shape, even though AVR doesn't use uMaker for
its own builds.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goal 5 — Adds `tests/bdshot_compile_test.cpp` that exercises BDShot.cpp via its intended user-facing pattern (`#include <AVR++/BDShot.cpp>` + explicit `template class` instantiation, per the README). `BDShotConfig::Debug::Pin` defaults to a dummy IOpin (Pin=8), so no stub config is required. The previous CI skip-note ("needs user config") was technically wrong — the actual reason BDShot.cpp can't compile standalone is that it's not a translation unit, it's an include-only .cpp; comment fixed.
Goal 6 — Workflow standardization: adds `make` to the apt-install line and `make --version` to the toolchain-versions step so AVR matches the other firmware repos' CI shape, even though AVR doesn't use uMaker for its own builds.
Test plan
🤖 Generated with Claude Code