OCD-5296 | Improve the styling and layout of embedded report iframes - #1520
Merged
Conversation
mattystank
marked this pull request as ready for review
July 14, 2026 19:08
andlar
reviewed
Jul 16, 2026
andlar
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ChplChartspage to improve the styling and layout of embedded report iframes. The main changes involve introducing custom styles for theCardContentandiframeelements to ensure better visual presentation and consistency.Styling improvements:
reportCardContentstyle tomakeStylesto remove default padding, hide overflow, and eliminate extra bottom padding from the last child, ensuring the embedded report fills the card cleanly.iframestyle tomakeStylesto remove borders, set width to 100%, display as a block, and adjust the bottom margin for better alignment within the card.Component usage updates:
reportCardContentstyle toCardContentand the newiframestyle to the embeddediframeelement, replacing inline and deprecated attributes for improved consistency and maintainability.[#OCD-5296]