Skip to content

fix: harden CommandValidator to cover missed absolute paths + sensitive-file exfil (issue #17) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chouzz merged 1 commit into from
Aug 31, 2026
Merged

fix: harden CommandValidator to cover missed absolute paths + sensitive-file exfil (issue #17) #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/remoteshell_mcp/command_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ class CommandValidator:
# Patterns for removing all files (but allow relative paths like ./test)
(r'\brm\s+.*-.*rf\s+\*', 'Remove all files in current directory'),
(r'\brm\s+.*-.*rf\s+\.\.(?:\s|$|/)', 'Remove parent directory'),

# Hardened (issue #17): absolute-path `rm -rf` under common user/system
# trees that the 11-path list missed, and destructive ops on individual files.
(r'\brm\s+.*-.*rf\s+(?:/home|/tmp|/mnt|/data|/opt|/srv|/media)(?:\s|$|/)',
'Remove absolute path under /home /tmp /mnt /data /opt /srv /media'),
(r'\brm\s+.*-.*rf\s+/\S+(?:/|(?:\s|$))',
'Remove arbitrary absolute path (individual file/dir)'),
# File-exfil / overwrite primitives that return secrets to the caller.
(r'\b(?:cat|cp|mv|tar|dd|scp|nc|rsync)\s+.*(?:/etc/shadow|/etc/passwd|/etc/sudoers|/root/\.|/home/.*?/\.ssh)',
'Exfiltrate or disclose sensitive system/private files'),
]

@classmethod
Expand Down