compatibility with older gcc bug: unnamed union members cannot be used in init#92
Open
mckaygerhard wants to merge 1 commit into
Open
compatibility with older gcc bug: unnamed union members cannot be used in init#92mckaygerhard wants to merge 1 commit into
mckaygerhard wants to merge 1 commit into
Conversation
… used in init This solves compilation in olders gcc due a unresolved bug in <gcc-4.6 that unnamed union members cannot be used in initializer (stupid win-hat developers, always later) Theres no fun in a cheap software that relies on to high dependences, due high dependences need modern hardware.. an modern hardware dont need memory savings: so please commit thi for possibility to have compton in many distros that already not have gcc 4.6+.
mckaygerhard
referenced
this pull request
in hun7err/compton
Feb 27, 2013
Collaborator
|
Sorry, but if you couldn't yet clearly see my attitude in #86 and #91, mckaygerhard:
|
fruchti
pushed a commit
to fruchti/compton
that referenced
this pull request
Feb 2, 2019
Previously, compton fails to stop draw_idle in some cases when sw_opti is enabled. sw_opti is a feature that limits the draw frequence to vblank frequence. It adds a delay to drawing when the screen is updated more frequently than the vblank frequence. However when the delay is not used (i.e. the screen is updated infrequent enough), compton will start drawing the frame directly without using the delay. And specically in this case, compton will fail to stop the draw_idle, causing a callback to be called once per loop of the mainloop, resulting in high CPU usage. Fixes chjj#92 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...ed in init
This solves compilation in olders gcc due a unresolved bug in <gcc-4.6 that unnamed union members cannot be used in initializer (stupid win-hat developers, always later)
Theres no fun in a cheap software that relies on to high dependences, due high dependences need modern hardware.. an modern hardware dont need memory savings:
so we the users that have older hardware with olders software need this please commit thi for possibility to have compton in many distros that already not have gcc 4.6+.