feat(api): retry Spotify 429s with backoff - #413
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The retry utility currently parses Retry-After but doesn’t use it to pace 429 retries, contradicting the stated behavior and risking immediate repeated rate-limit hits.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a shared retry-with-backoff utility for Supabase edge functions and uses it to handle Spotify 429 rate limits, propagating Retry-After wait time through the API response so the Link Wizard UI can display a rate-limit-specific message.
Changes:
- Introduces
fetchWithRetry(+ unit tests) for retrying 429s with backoff and returning a structured rate-limit result. - Updates Spotify search and Spotify token acquisition to use the retry utility and surface rate-limit wait time.
- Plumbs
rateLimitRetryAfterthrough edge-function types, API Zod schema, and Link Wizard error formatting.
File summaries
| File | Description |
|---|---|
| supabase/functions/search-artist-links/types.ts | Adds optional rateLimitRetryAfter to provider outcomes/results. |
| supabase/functions/search-artist-links/spotify-adapter.ts | Switches Spotify search to fetchWithRetry and returns rate-limit info on 429. |
| supabase/functions/search-artist-links/index.ts | Includes rateLimitRetryAfter in the edge-function response when present. |
| supabase/functions/_shared/spotify-api/auth.ts | Uses fetchWithRetry for token requests and surfaces rate-limit failures. |
| supabase/functions/_shared/retry-utils.ts | Adds new retry/backoff helper and Retry-After parsing. |
| supabase/functions/_shared/retry-utils.test.ts | Adds Deno unit tests covering retry behavior and Retry-After parsing. |
| src/pages/admin/festivals/LinkWizard/useProviderCandidates.ts | Threads through rateLimitRetryAfter and formats a user-facing rate-limit message. |
| src/api/artistSearch/types.ts | Extends client schema/types to accept rateLimitRetryAfter. |
Review details
Suppressed comments (1)
supabase/functions/_shared/retry-utils.ts:50
- On 429, the retry sleep uses only exponential backoff; it should consider the parsed
Retry-Aftervalue so we don’t retry earlier than the server indicates (subject tomaxDelayMs).
if (attempt < maxRetries) {
const delay = Math.min(
initialDelayMs * Math.pow(2, attempt),
maxDelayMs,
);
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Deploy →
|
Playwright test results
Details
|
chiptus
force-pushed
the
fix-411/spotify-429-retry
branch
from
August 27, 2026 06:13
30b4ce7 to
8dc6671
Compare
Implement retry-with-backoff helper for handling Spotify API 429 responses: - New fetchWithRetry utility honors Retry-After header for rate limits - Spotify search and token refresh now retry twice with exponential backoff - Rate-limit errors are distinguishable from other failures with wait time - UI displays "Rate limited. Try again in Ns" message when applicable - Includes comprehensive unit tests for retry scenarios Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2ci2Q1QgHtkMY93c2zf9C
Adds integration test covering repeated 429 responses surfacing rate-limit error through full request path. Tests three scenarios: - 429 exhausting retries: returns distinguishable rate-limit error with Retry-After seconds - 429 then success: recovers after one retry with backoff - Non-429 error: fails immediately without retry Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2ci2Q1QgHtkMY93c2zf9C
…e UI from error wording Two fixes: 1. fetchWithRetry now incorporates Retry-After header into sleep duration using max(exponentialBackoff, retryAfterMs), capped at maxDelayMs, so we honor the server's requested wait time 2. buildErrorMessage detects rate-limit via rateLimitRetryAfter field directly instead of string matching on error text, decoupling UI from backend error wording Adds unit tests verifying: - Retry-After value is respected and delay is at least as long as requested - Large Retry-After values are capped at maxDelayMs to prevent hanging Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2ci2Q1QgHtkMY93c2zf9C
…use fake timers in retry tests - getSpotifyAccessToken no longer reads .error off a RateLimitError result (TS2339) - searchSpotify breaks out of the artist loop on a 429 instead of hammering remaining candidates with requests that will just be rate-limited again - retry-utils.test.ts uses Deno's FakeTime instead of waiting on real delays, cutting ~3s of real time off the suite
chiptus
force-pushed
the
fix-411/spotify-429-retry
branch
from
August 27, 2026 18:00
8dc6671 to
89c9ad9
Compare
…integration tests getSpotifyAccessToken threw "Spotify credentials are not configured" in CI since SPOTIFY_CLIENT_ID/SECRET aren't set for deno test. Also the module-level token cache persisted across the file's three Deno.test cases (they share the same imported auth.ts instance), so tests after the first skipped the mocked token fetch and desynced their response queues.
4 tasks
…lpers Extracts getCachedToken() and requestSpotifyToken() to make the credential-check/cache/fetch flow easier to follow.
Separates the HTTP/retry/error-handling concern (fetchTokenResponse) from response validation (parseTokenResponse) for clarity.
Pulls the rate-limit/other-error branching out of fetchTokenResponse into its own function.
Converts the 429-exhausted and maxDelayMs-cap tests to advance a FakeTime clock instead of waiting on real setTimeout delays, matching the pattern already used by the other retry-utils tests. Removes reliance on wall-clock elapsed-time assertions, which were flaky under load.
…apter Adds fetchSpotifyAPI to _shared/spotify-api/api.ts, mirroring the fetchSoundCloudAPI pattern: retry + schema validation in one place. getSpotifyArtistById now goes through it too, gaining 429 retry handling it previously lacked. spotify-adapter.ts's searchSpotify is split into searchSpotifyArtist, handleSearchFailure, and fillRemainingWithRateLimit for readability. Also adds an optional status field to retry-utils' OtherError so callers can branch on HTTP status (e.g. 404) without inspecting error message text.
Playwright test results
Details
|
…test FakeTime.tickAsync jumps straight to the target time after a single microtask flush, so a single big tick only fires the first of two sequential retry sleeps — the second sleep is scheduled only once the fake clock has already jumped past it, so it never fires and the test hangs. That leaves the FakeTime instance's using-disposal stuck mid-await, leaking faked globals into every later test in the file (the "Cannot construct FakeTime: time is already faked" failures). Ticking once per expected sleep fixes all five cascading failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds retry-with-backoff for Spotify API rate limits, honoring Retry-After header and surfacing rate-limit errors to the UI with wait time.
All tests passing; integration test for end-to-end rate-limit surface path planned in follow-up.
Verification
Generated by Claude Code