Skip to content

Fix Windows path normalization regressions in state discovery and terminal folder links - #1

Draft
LIU-Yinyi with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-failing-github-actions-job
Draft

LIU-Yinyi with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Aug 11, 2026 •

Copy link
Copy Markdown

The test (windows-latest, 22) job was failing due to cross-platform path handling bugs: Windows absolute paths were being re-resolved as relative, and folder hyperlink URIs were host-dependent. This caused invalid state-file paths (D:\...\C:\...) and mismatched formatted output in Windows CI.

  • State location resolution

    • Updated resolveStateLocation to treat both POSIX-absolute and Windows-absolute paths as already absolute before resolving against cwd.
    • Prevents accidental prefixing of Windows absolute --codex-home / CODEX_HOME values.
  • Terminal folder hyperlink stability

    • Updated folderLink URI construction to emit stable file:// links for:
      • POSIX absolute paths (/work/... → file:///work/...)
      • Windows drive paths (C:\... → file:///C:/...)
    • Keeps output deterministic across runner OSes.
  • Focused regression coverage

    • Added unit coverage for:
      • absolute Windows codexHome when resolved under posix-mode parsing
      • stable hyperlink encoding for absolute folder paths
const codexHome = isAbsolutePath(configuredHome)
  ? configuredHome
  : parser.resolve(cwd, configuredHome);

Co-authored-by: LIU-Yinyi <43030043+LIU-Yinyi@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job test (windows-latest, 22) Fix Windows path normalization regressions in state discovery and terminal folder links Aug 11, 2026
Copilot AI requested a review from LIU-Yinyi August 11, 2026 21:43
Co-authored-by: LIU-Yinyi <43030043+LIU-Yinyi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants