Skip to content

poteto-mode: run interrogate only for a contested design, as Lauren's pstack does (2.2.4) - #66

Merged
chhoumann merged 2 commits into
mainfrom
fix/65-drop-pr-gate
Nov 6, 2026
Merged

chhoumann merged 2 commits into
mainfrom
fix/65-drop-pr-gate

Conversation

@chhoumann

@chhoumann chhoumann commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

poteto-mode sent every bug fix, feature, and refactoring diff to an interrogate panel before Opening a PR. Lauren's pstack never had that gate. At cursor/plugins c742dd6, poteto-mode runs interrogate only for a contested design, and the Feature playbook's step 7 says "If the design is contested, interrogate before shipping."

The gate was the port's own rule. 1.0.1 added it to t3-tools.md, 1.0.6 added its review loop (fix-diff rounds, a verifier that runs the real artifact after each fix round, a three-round cap), and 2.0.0-rc.1 moved it into an anchored insert in tools/substitutions.json. So every change in a T3 session paid for a multi-model adversarial panel that Lauren's pstack saves for a contested design.

What changed

  • tools/substitutions.json loses the insert, so poteto-mode's trigger is Lauren's line, byte for byte.
  • poteto-mode/SKILL.md is a declared fork, so a rule change does not reach it on its own. It took the change through git merge-file of its derived text before and after the rule change. That removed only the gate line. The fork keeps its four rules from Michael Denyer's pstack-claude, so its tools/forks.json entry stays.
  • tests/sync.test.mjs drops the case that pinned the insert, and CONTRIBUTING no longer names the review loop as an example of an anchored insert.
  • Release 2.2.4: VERSION, the generated manifests, the README's tag example, and a CHANGES.md entry. The 2.0.0-rc.1 rows that list the gate as kept now say 2.2.4 dropped it.

Nothing else in the repo required the gate. interrogate, its interrogate reviewers sheet line, BLOCKED: independent review, the closed-review-gate rule, and Autopilot's cross-family verifier lanes stay. The release syncs nothing from Lauren's pstack and stays at c742dd6. Neither hooks file changes.

Checks

  • git log -S "before Opening a PR" -- pstack/ in cursor/plugins finds no commit, so upstream never carried the gate.
  • bun tools/sync.mjs <pstack|cursor-team-kit|thermos> c742dd6 --dry-run, against a local clone at that SHA: exit 0 for each, with no undeclared fork, denylist hit, or unused substitution. The SKILL.md fork still counts 7 changed lines, the four pstack-claude rules.
  • bun install --frozen-lockfile and bun tools/generate.mjs --check: 17 generated files current.
  • GIT_CONFIG_GLOBAL=/dev/null bun test tests/ --timeout 30000: 553 pass, 47 skip, 0 fail.
  • One review round by Claude Fable 5.1 and GPT-6 Astra at xhigh: no critical or high finding. Two medium findings corrected the release notes: 2.2.4 still needs the usual update on Codex, and the gate lived in t3-tools.md before it became an insert.

Thanks to @PrinceD96 for the report.

Closes #65


Note

Medium Risk
Changes default PR workflow: fewer changes go through interrogate before open, which could miss cross-model review on non-contested work; low security impact but reviewers should be aware of the stricter alignment with upstream.

Overview
Behavior change: poteto-mode no longer requires the interrogate skill with the interrogate reviewers panel before Opening a PR for every bug fix, feature, or refactoring diff. Interrogate is triggered only for a contested design, matching Lauren’s pstack at the current pin.

The port removed the anchored substitution in tools/substitutions.json that appended that gate after the contested-design line. plugins/pstack/skills/poteto-mode/SKILL.md drops the corresponding trigger bullet (the forked skill was merged so only that line goes away).

Tests and docs: tests/sync.test.mjs no longer asserts the removed insert. CONTRIBUTING no longer cites the review loop as an example of an anchored insert. CHANGES and the adaptation table rows note that 2.2.4 dropped the gate.

Release: Version 2.2.4 everywhere (VERSION, package.json, Claude/Codex plugin JSON, marketplace, README tag example).

Reviewed by Cursor Bugbot for commit 5a5d0ab. Bugbot is set up for automated code reviews on this repo. Configure here.

Since 1.0.1 the port sent every bug fix, feature, and refactoring diff
to the interrogate reviewers panel before Opening a PR, and 1.0.6 added
its review loop: fix-diff rounds, a verifier that runs the real
artifact after each fix round, and a three-round cap. The rule lived in
the port's t3-tools.md through 1.0.14 and has been an anchored insert
after Lauren's contested-design trigger since 2.0.0-rc.1. Lauren's
pstack never had that gate. At c742dd6 poteto-mode runs interrogate
only for a contested design, and Feature step 7 says the same (#65).

Delete the insert so the trigger is Lauren's line. The poteto-mode fork
takes the change through a three-way merge of its derived text before
and after, which removes only the gate line and keeps its four rules
from Michael Denyer's pstack-claude. Drop the test that pinned the
insert, and stop naming the review loop as an example anchored insert
in CONTRIBUTING.
poteto-mode runs interrogate only for a contested design, as Lauren's
pstack does (#65). VERSION, the manifests, package.json, and the
README's pinned installer command move to 2.2.4, a patch release that
rewords skill text and changes no setting or workflow. On Codex,
update reruns after it as after every release. It syncs nothing from
upstream, so every component stays pinned at c742dd6. The 2.0.0-rc.1
rows that list the gate as kept now say 2.2.4 dropped it.
@chhoumann
chhoumann marked this pull request as ready for review November 6, 2026 19:03
@chhoumann
chhoumann merged commit f5aafe8 into main Nov 6, 2026
12 checks passed
@chhoumann
chhoumann deleted the fix/65-drop-pr-gate branch November 6, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poteto-mode still gates every PR on interrogate, which upstream c742dd6 dropped

1 participant