Repository navigation
poteto-mode: run interrogate only for a contested design, as Lauren's pstack does (2.2.4) - #66
Merged
Merged
Conversation
Since 1.0.1 the port sent every bug fix, feature, and refactoring diff to the interrogate reviewers panel before Opening a PR, and 1.0.6 added its review loop: fix-diff rounds, a verifier that runs the real artifact after each fix round, and a three-round cap. The rule lived in the port's t3-tools.md through 1.0.14 and has been an anchored insert after Lauren's contested-design trigger since 2.0.0-rc.1. Lauren's pstack never had that gate. At c742dd6 poteto-mode runs interrogate only for a contested design, and Feature step 7 says the same (#65). Delete the insert so the trigger is Lauren's line. The poteto-mode fork takes the change through a three-way merge of its derived text before and after, which removes only the gate line and keeps its four rules from Michael Denyer's pstack-claude. Drop the test that pinned the insert, and stop naming the review loop as an example anchored insert in CONTRIBUTING.
poteto-mode runs interrogate only for a contested design, as Lauren's pstack does (#65). VERSION, the manifests, package.json, and the README's pinned installer command move to 2.2.4, a patch release that rewords skill text and changes no setting or workflow. On Codex, update reruns after it as after every release. It syncs nothing from upstream, so every component stays pinned at c742dd6. The 2.0.0-rc.1 rows that list the gate as kept now say 2.2.4 dropped it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poteto-mode sent every bug fix, feature, and refactoring diff to an
interrogatepanel before Opening a PR. Lauren's pstack never had that gate. At cursor/pluginsc742dd6, poteto-mode runsinterrogateonly for a contested design, and the Feature playbook's step 7 says "If the design is contested,interrogatebefore shipping."The gate was the port's own rule. 1.0.1 added it to
t3-tools.md, 1.0.6 added its review loop (fix-diff rounds, a verifier that runs the real artifact after each fix round, a three-round cap), and 2.0.0-rc.1 moved it into an anchored insert intools/substitutions.json. So every change in a T3 session paid for a multi-model adversarial panel that Lauren's pstack saves for a contested design.What changed
tools/substitutions.jsonloses the insert, so poteto-mode's trigger is Lauren's line, byte for byte.poteto-mode/SKILL.mdis a declared fork, so a rule change does not reach it on its own. It took the change throughgit merge-fileof its derived text before and after the rule change. That removed only the gate line. The fork keeps its four rules from Michael Denyer's pstack-claude, so itstools/forks.jsonentry stays.tests/sync.test.mjsdrops the case that pinned the insert, and CONTRIBUTING no longer names the review loop as an example of an anchored insert.VERSION, the generated manifests, the README's tag example, and aCHANGES.mdentry. The 2.0.0-rc.1 rows that list the gate as kept now say 2.2.4 dropped it.Nothing else in the repo required the gate.
interrogate, itsinterrogate reviewerssheet line,BLOCKED: independent review, the closed-review-gate rule, and Autopilot's cross-family verifier lanes stay. The release syncs nothing from Lauren's pstack and stays atc742dd6. Neither hooks file changes.Checks
git log -S "before Opening a PR" -- pstack/in cursor/plugins finds no commit, so upstream never carried the gate.bun tools/sync.mjs <pstack|cursor-team-kit|thermos> c742dd6 --dry-run, against a local clone at that SHA: exit 0 for each, with no undeclared fork, denylist hit, or unused substitution. The SKILL.md fork still counts 7 changed lines, the four pstack-claude rules.bun install --frozen-lockfileandbun tools/generate.mjs --check: 17 generated files current.GIT_CONFIG_GLOBAL=/dev/null bun test tests/ --timeout 30000: 553 pass, 47 skip, 0 fail.updateon Codex, and the gate lived int3-tools.mdbefore it became an insert.Thanks to @PrinceD96 for the report.
Closes #65
Note
Medium Risk
Changes default PR workflow: fewer changes go through interrogate before open, which could miss cross-model review on non-contested work; low security impact but reviewers should be aware of the stricter alignment with upstream.
Overview
Behavior change: poteto-mode no longer requires the interrogate skill with the
interrogate reviewerspanel before Opening a PR for every bug fix, feature, or refactoring diff. Interrogate is triggered only for a contested design, matching Lauren’s pstack at the current pin.The port removed the anchored substitution in
tools/substitutions.jsonthat appended that gate after the contested-design line.plugins/pstack/skills/poteto-mode/SKILL.mddrops the corresponding trigger bullet (the forked skill was merged so only that line goes away).Tests and docs:
tests/sync.test.mjsno longer asserts the removed insert. CONTRIBUTING no longer cites the review loop as an example of an anchored insert. CHANGES and the adaptation table rows note that 2.2.4 dropped the gate.Release: Version 2.2.4 everywhere (VERSION,
package.json, Claude/Codex plugin JSON, marketplace, README tag example).Reviewed by Cursor Bugbot for commit 5a5d0ab. Bugbot is set up for automated code reviews on this repo. Configure here.