Repository navigation
ci: move the release toolkit to v5.0.0 and the App client ID - #225
Merged
Merged
Conversation
Pin every obsidian-plugin-workflows reusable workflow to v5.0.0. v5 replaces the prepare workflow's app-id input with client-id, so the prepare stub now passes vars.RELEASE_APP_CLIENT_ID. A dryRun dispatch now also mints a read-only App token to check the credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chhoumann/obsidian-plugin-workflowsreusable workflow to v5.0.0 (d6b3b8c2cf460059238043b32a08dcaa3be4828f).app-idinput withclient-id, becauseactions/create-github-app-tokendeprecatesapp-id. The prepare stub now passesclient-id: ${{ vars.RELEASE_APP_CLIENT_ID }}. TheRELEASE_APP_CLIENT_IDrepository variable is set to the App's Client ID.dryRundispatch of Prepare release now also mints a read-only App token and checks its slug. It still opens no release PR.Test plan
dryRun=true: https://github.com/chhoumann/MetaEdit/actions/runs/40102101553. Check release-bot App minted a token for the expected slug, Open release PR was skipped, and open PRs, release branches and the latest release were unchanged.Note
Medium Risk
Touches release automation and GitHub App authentication; misconfigured
RELEASE_APP_CLIENT_IDcould break prepare/dry-run until fixed, but scope is limited to workflow stubs.Overview
Upgrades the release pipeline to
chhoumann/obsidian-plugin-workflowsv5.0.0 by repinning the reusable workflows inrelease-prepare.yml,release-trigger.yml, andrelease.yml.Prepare release now passes
client-idfromvars.RELEASE_APP_CLIENT_IDinstead ofapp-id, matching v5 and the deprecatedactions/create-github-app-tokenapp-idinput. Comments note thatdryRunalso mints a read-only App token and verifies the slug without opening a release PR.No application code changes; release policy, secrets, and other workflow inputs stay the same aside from the toolkit pin and client ID wiring.
Reviewed by Cursor Bugbot for commit 96a824d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Upgrade release workflows to toolkit v5.0.0 and use App client ID
prepare,validate, andreleasejobs in release-prepare.yml, release-trigger.yml, and release.ymlapp-idinput (RELEASE_APP_ID) with theclient-idinput (RELEASE_APP_CLIENT_ID) in the prepare jobRELEASE_APP_IDis no longer used; ensureRELEASE_APP_CLIENT_IDis set, and App credentials are now checked during manual dry runs without opening or refreshing the release PRMacroscope summarized 96a824d.