Repository navigation
fix(bench): version the checkgate-core path dependency for cargo-deny - #24
Merged
Merged
Conversation
…go-deny The bench crate added in #22 declared `checkgate-core = { path = "../core" }` with no version, which cargo-deny's `wildcards = "deny"` rejects, failing the Supply chain job on dev. Declare it as the server crate does (`version = "0.1.0", path = "../core"`). Lockfile unchanged. `cargo deny --all-features check`: advisories, bans, licenses, sources ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bench/crate added in #22 declaredcheckgate-coreby path without a version. cargo-deny'swildcards = "deny"rejects that, which fails the Supply chain job on dev (bans FAILED: found 1 wildcard dependency for crate 'checkgate-bench'). Declared the same way as inserver/Cargo.toml. Lockfile unchanged.Locally:
cargo deny --all-features check→ advisories, bans, licenses, sources ok;cargo auditclean.