madmail: bump default ref to v2.29.1 - #50
Merged
Merged
Conversation
v2.23.2 tests still call snapshot.is_verified, which current deltachat-rpc-server dropped. v2.29.1 uses e2ee_avail.
missytake
approved these changes
Sep 23, 2026
missytake
left a comment
missytake
left a comment
Contributor
There was a problem hiding this comment.
Let's hope this fixes the nightly workflow :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly
deploy-madmailusesDEFAULT_REF(no--source), currentlyv2.23.2.That job failed on
contact.get_snapshot().is_verifiedafter core v2.61.0 removed the field. Madmail v2.29.1 has the harness one2ee_avail(themadorg/madmail#174).since the musl GitHub asset is not up yet (It will be after the next madmail release), cmlxc already falls back to a source build of the same tag.