Fix forward word deletion at the end of a text input - #1058
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
textinput, Alt+D panics when the cursor is on the final rune of the value. When the cursor is on the final rune of a word followed by another word, it also deletes that next word (#1056).Change
Scan from the current rune using a separate end index. Only skip whitespace when deletion starts on whitespace; then stop at the next word boundary. This avoids indexing beyond the value and preserves the existing behavior for deletion starting on a space. The new
Update-driven regression covers the reported cases and a Unicode rune.Validation
go test ./textinput -count=1— passed.go test ./...— passed.go test -race ./textinput -count=1— passed.go vet ./...,gofmt -don changed files, andgit diff --check— passed.Tested with Go 1.27.1 against the module's Go 1.25 baseline. Prepared with AI assistance.
Fixes #1056.