Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…side the AugurUUID) Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
|
|
||
| import uuid | ||
| import typing | ||
| from collectoss.util.enums import ForgePlatformType |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused ForgePlatformType imported from collectoss.util.enums (unused-import)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a new python Enum representing the "platform type" - a new word for the same concept we were already using, primarily in
ContributorUUID. This concept assigns a magic integer of 1 for github contributors and 2 for gitlab. This enum both formalizes and renames this magic number into aForgePlatformType, allowing us to keep the usefulness of knowing the type (i.e. API compatibility) for a given git forge, while moving it to a more appropriate structure. Previously these values were naievely stored in their own database table,platformwhich is being deprecated.This PR contributes to one step of #293
Notes for Reviewers
Functionally this just adds an Enum that isnt being used anywhere.
Future PRs will address the primary task of connecting this Enum to the
forge_instancestableSigned commits
Generative AI disclosure
Please select one option: