Skip to content

fixing precedence by parenthesizing the actions - #499

Open
EngCaioFonseca wants to merge 1 commit into
chaoss:mainfrom
EngCaioFonseca:fix/toss-pr-acceptance-or-precedence
Open

EngCaioFonseca wants to merge 1 commit into
chaoss:mainfrom
EngCaioFonseca:fix/toss-pr-acceptance-or-precedence

Conversation

@EngCaioFonseca

@EngCaioFonseca EngCaioFonseca commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Please include a summary of the change.
    The actions in the implementation had no precedence before, between AND/OR so this could introduce errors in the count. AND binds tighter than OR, so the way it was structured it could include other repos the way the SQL was parsed.

This PR fixes #
Structuring more appropriately considering the precedence and parenthesizing the parsing fix this.
So now it will select it appropriately merged or ready for review requests.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Generative AI disclosure

Please select one option:

  • This contribution was NOT assisted or created by Generative AI tools.
  • This contribution was assisted or created by Generative AI tools.

If AI tools were used, please provide details below:
- What tools were used? Claude
- How were these tools used? Not in the implementation itself, but with a exploratory investigation of CollectOSS DB and schemas.
- Did you review these outputs before submitting this PR? Yes.

Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
@MoralCode

Copy link
Copy Markdown
Contributor

Make sure you fill out the PR template fully.

I'm also curious how you found this. I didnt think we were using those metrics endpoints

@MoralCode MoralCode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@EngCaioFonseca

Copy link
Copy Markdown
Contributor Author

I'm doing an exploratory search/investigation into the db and schema. Looking for potential places for optimizations, in the context of indexing, normalization, implementations, etc, as we discussed today.
So, I've ran an exploratory audit as well, which highlighted a few places (bugs) where it could be simply fixed.

@MoralCode MoralCode added the API Related to metrics API's label Sep 29, 2026
@MoralCode MoralCode added this to the v1.2 milestone Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Related to metrics API's

Projects

Development

Successfully merging this pull request may close these issues.

2 participants