fixing precedence by parenthesizing the actions - #499
Open
EngCaioFonseca wants to merge 1 commit into
Open
EngCaioFonseca wants to merge 1 commit into
EngCaioFonseca wants to merge 1 commit into
Conversation
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Contributor
|
Make sure you fill out the PR template fully. I'm also curious how you found this. I didnt think we were using those metrics endpoints |
Contributor
Author
|
I'm doing an exploratory search/investigation into the db and schema. Looking for potential places for optimizations, in the context of indexing, normalization, implementations, etc, as we discussed today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The actions in the implementation had no precedence before, between AND/OR so this could introduce errors in the count. AND binds tighter than OR, so the way it was structured it could include other repos the way the SQL was parsed.
This PR fixes #
Structuring more appropriately considering the precedence and parenthesizing the parsing fix this.
So now it will select it appropriately merged or ready for review requests.
Notes for Reviewers
Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? Claude
- How were these tools used? Not in the implementation itself, but with a exploratory investigation of CollectOSS DB and schemas.
- Did you review these outputs before submitting this PR? Yes.