Repository navigation
Adding cache schema version - #1204
Merged
Merged
Conversation
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Contributor
|
#1189 made changes to the schema, so this may need to change to account for that |
MoralCode
reviewed
Aug 25, 2026
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
EngCaioFonseca
marked this pull request as ready for review
August 30, 2026 23:51
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
EngCaioFonseca
force-pushed
the
cache_schema_version
branch
from
August 30, 2026 23:54
6f12892 to
ce7a917
Compare
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
EngCaioFonseca
moved this from In Progress
to Testing | Waiting on PR response | Blocked
in Aspen Project Board
MoralCode
previously requested changes
Sep 28, 2026
Contributor
There was a problem hiding this comment.
Love the change in this file to unify our connection strings! this will be a great place to pivot to storing the cache db somewhere more persistent/in the same postgres instance
Comment on lines
+640
to
+641
| # Reconcile indexes after migrations so they reflect the final schema. | ||
| _ensure_repo_id_indexes() |
Contributor
There was a problem hiding this comment.
we can version the indexes alongside the schema if we were using sqlalchemy for our data models
Replace the historical labels migration with a data-preserving baseline and generate numeric Alembic revisions. Resolve migration paths relative to the config and use snapshot-free advisory-lock polling. Add PostgreSQL regression checks for baseline adoption, future upgrades, revision generation, and lock cleanup. Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Collaborator
|
@EngCaioFonseca @MoralCode LMK when this PR is ready to be tested |
MoralCode
reviewed
Sep 30, 2026
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
cdolfi
requested changes
Oct 1, 2026
cdolfi
left a comment
cdolfi
left a comment
Collaborator
There was a problem hiding this comment.
Something in this pr is making Contribution File Heatmap endlessly load, tested dev and did not see the same behavior
Signed-off-by: Caio Fonseca <engcaiofonseca@protonmail.com>
Contributor
Author
Resolved. It was necessary to ensure that the app and workers wait for the db-init to finish successfully and no redis flush before this. |
github-project-automation
Bot
moved this from Testing | Waiting on PR response | Blocked
to Sprint 55
in Aspen Project Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Change Description
This solves #1198 and adds the cache schema versioning as well as lay the groundwork for the follow up steps or making the cache persistent.
The cache schema is now versioned with Alembic. It runs on startup: a fresh cache gets stamped at the latest version, and an existing cache gets any missing migrations applied automatically. Base tables are still created with the raw CREATE blocks in db_init.py, so adding a new table works exactly like before. Alembic only handles changes to existing tables.
A few things added for the cache long-term:
This is also groundwork for making the cache persistent instead of rebuilt on every boot.
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? Claude - Opus 4.8; GPT - 5.6 Sol
- How were these tools used? Draft, review iteration.
- Did you review these outputs before submitting this PR? Yes.