Repository navigation
Merge dev into main: pstack refresh and the PR links check - #1531
Merged
Merged
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
`how explorer` was also the general role for a delegate that reads and reports (the mode's default delegation, recall, automate-me and maintain-verification-skill). The `how` skill stops using explorers, so the role keeps its job under the name `reader`, stays read-only, and `how explainer` is retired. Setup carries a `how explorer` model over to `reader` and drops `how explainer`. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…at the border Take pstack bf0c7cd (#1236) for statechart. When SANY cannot read a spec, the CLI reports its error section (with line and column, up to 40 lines) instead of a Java stack. Arrows into a parent state end at the parent's border. The tests and the Login corpus follow. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
`how` now starts one fresh subagent on the `reader` role that explores and explains in one pass, and the main chat presents the result. The complexity check, the explorers, the explainer and both prompt templates are gone, along with the glossary entries that only described them. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…mple Take pstack bf0c7cd (#1236) for the reflect synthesizer. The example of a detail that goes stale no longer names a model. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
The mode no longer runs `how` on a nontrivial change. Investigation, Feature, Bug fix, Perf issue, Hillclimb and Refactoring trace the code themselves, and the Multi-phase plan appendix no longer names `how`. Architect traces the systems its invoker's evidence leaves unexplained and keeps its start from that evidence. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…ent can settle Take pstack bf0c7cd (#1236) for sharpen. The rewritten prompt asks the agent to prototype any choice an experiment can settle and to recommend an option from what it observed. Product and preference choices stay with the owner. The README row and the guide section say the same. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Comment Sicko traces a named symbol or call through the nearby code and its call sites. It still ends its report with `needs: why on <symbol>` when a claim rests on history, and no-comments and the build guide say the same. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Take the pstack bf0c7cd (#1236) rule that a judge never shares the parent's vendor, in mmwstack's host-neutral wording. A vendor is the company that trains the model, and models from one vendor count as one vendor even when the vendor names its lines differently. Every place that states judge or reviewer independence says vendor instead of family. No model is named. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
The README skill list, guides 02, 03, 04 and 10, and the three Benny files no longer say the mode, the Investigation playbook, architect or a Benny automation runs `how`. Guide 03 now describes `how` as one read-only subagent instead of two to four explorers. `/how` stays where it is a command the reader types. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
recall step 4 starts one read-only investigator per source the topic touches on the `judgment and prose` role, with the tools that source needs, instead of handing the sweep to the `why` skill. The `reader` role does not fit because its droid cannot run git or `gh`. The glossary gains the Recall investigator term. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
`why` answers from the record, not the code. It reads the commits and PR discussions behind the target and each later change, looks at other sources when the trail is thin, cites what the authors wrote, marks its own inferences, and says what the record does not answer. It starts no subagent. The investigators, the synthesizer, the confidence framework and the twelve `references/` files are gone, with the `why investigators` and `why synthesizer` roles (now retired names in `setup-mmwstack`) and the investigation glossary terms that only described them. The glossary keeps Null result and Evidence gap, which `why` and Recall still use. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
blast-radius pulls the PR and its commits itself and drops the "same rules as why" pointer. teach no longer narrows `why` because of a full sweep that does not exist. The README row and the understand guide describe `why` as an answer from the record that cites the authors, marks inferences, and says what the record does not answer. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Marks mmwstack as caught up with pstack 0.15.42 (cursor/plugins bf0c7cd, #1236). Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
why is now one short file that starts no subagent, so Comment Sicko runs it on a symbol itself when a claim rests on history. Drop the `needs: why` handoff from the role, the no-comments step 1 and the build-and-clean guide. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
The script reads one Event JSON from stdin and writes one Decision JSON line. It denies a `gh pr create` or `origin pr create` command that targets the default branch with a body that has no closing keyword. It answers allow when it cannot parse the command, find the body, or find the default branch. It names no harness, so any host can run it. Refs #1528 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
A closing keyword closes an issue only when the PR merges into the default branch. The paragraph tells the PR author when to write `Closes #<issue>`, when to leave it out for a child PR, and which PR closes the issues of a project branch. Refs #1528 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…upstream chore(upstream): refresh pstack from cursor/plugins at bf0c7cd8
…tatechart feat(mmwstack): follow pstack on sharpen, reflect, statechart and judge vendor
…pstack refactor(mmwstack): follow pstack and cut how to one file, rename how explorer to reader
…pstack refactor(mmwstack): follow pstack and cut why to one file, recall starts its own investigators
…cy in check-pr-links Refs #1528 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
feat(mmwstack): require closing keywords in PR bodies and add check-pr-links
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The owner wants
devandmainin sync, locally and on the remote.mainlagsdevby 23 commits, anddevlacks the 8 merge commits that earlier release PRs left onmain. This delivers #1530.What changed
main: the pstack refresh, the sharpen and statechart skills, the new how and why, and the PR links check.[skip ci]as in Merge dev into main: mmwstack and framework-mode #1515 and Merge dev into main: mmwstack advisor #1517.Scope
upstream/pstack/andmmwstack/, outside the release workflow's paths.devto the merge commit puts both branches on one commit. That is a push, not a PR.Blast Radius
Door: two-way.
mainhas no unique content, so a revert of the merge commit restores it.Verification
git diff origin/main origin/devis the 129 files of those five PRs, andmainhas no commit outside merge commits.mainanddevhave no branch protection and no ruleset, and no PR is open.