feat(chelm): resolve ${image_name} and ${registry_repo_prefix} in tests - #482
Merged
Rodrigo-Munoz-Salas merged 1 commit intoSep 16, 2026
Conversation
The previous sdk bump made `chelm generate` accept the two new markers
at build time, but testResolver silently returned "" for them —
downstream chart tests using the split hub/image/tag shape rendered
empty image fields.
Example that now resolves under TestParams{Registry:"cgr.test",
Repository:"chainguard/test"}:
global:
hub: ${registry_repo_prefix} # cgr.test/chainguard/test
proxy:
image: ${image_name} # <lowercased imageID>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
elizadimarco
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Teaches chelm's test resolver to substitute the two markers added
upstream in chainguard.dev/sdk v0.1.270 (${image_name} and
${registry_repo_prefix}). The previous sdk dep bump was incomplete —
chelm test's resolveField switch had no cases for the new fields,
so downstream chart tests that use the split hub/image/tag shape
failed with empty image renders.
Follows #478.
Test plan
go build ./...andgo test ./...pass in the chelm module.pipeline goes green once a new tw release ships and stereo's
os/tw.yaml auto-bumps.
🤖 Generated with Claude Code