fix: parse and write replaces_priority in the installed apk db - #2497
Open
lyoung-confluent wants to merge 1 commit into
Open
lyoung-confluent wants to merge 1 commit into
lyoung-confluent wants to merge 1 commit into
Conversation
types.PackageInfo/types.Package had no field for a package's replaces_priority, so the value from .PKGINFO was silently dropped and never written to /lib/apk/db/installed (no q: line), unlike upstream apk-tools. Add ReplacesPriority and plumb it through parsing and writing, mirroring ProviderPriority, and guard the new q: line to only write when non-zero (matching apk-tools' database.c). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types.PackageInfo/types.Packagehad no field for a package'sreplaces_priority, so the value from.PKGINFOwas silently dropped and never written to/lib/apk/db/installed(noq:line), unlike upstreamapk-tools.Adds
ReplacesPriorityto both structs and plumbs it through parsing (.PKGINFO→ParsePackage) and writing (PackageToInstalled), mirroring howProviderPriority/k:already works. Theq:line is only written when non-zero, matchingapk-tools'database.c.Testing: added round-trip coverage in
installed_test.go(write → parse) for both the zero case (noq:line) and non-zero case.