feat(build): add PrefetchIndexes for resolving against one index snapshot - #2488
Draft
markusthoemmes wants to merge 1 commit into
Draft
markusthoemmes wants to merge 1 commit into
markusthoemmes wants to merge 1 commit into
Conversation
…shot Resolving many image configurations re-fetches and revalidates the repository indexes for every configuration, variant, and architecture, which is a large number of HEAD and GET round-trips and, because each resolve issues its own HEAD, can bind different architectures to different index generations - so a package published to one architecture mid-resolve resolves as absent on the other. PrefetchIndexes fetches each repository/architecture index once and returns a snapshot; passing it via WithPrefetchedIndexes makes GetRepositoryIndexes return it verbatim, so every resolve shares one consistent generation and the index round-trips collapse to a single fetch per repository and architecture. The snapshot is opt-in and does not change behaviour for callers that do not pass it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving many image configurations re-fetches and revalidates the repository indexes for every configuration, variant, and architecture, which is a large number of HEAD and GET round-trips and, because each resolve issues its own HEAD, can bind different architectures to different index generations - so a package published to one architecture mid-resolve resolves as absent on the other. PrefetchIndexes fetches each repository/architecture index once and returns a snapshot; passing it via WithPrefetchedIndexes makes GetRepositoryIndexes return it verbatim, so every resolve shares one consistent generation and the index round-trips collapse to a single fetch per repository and architecture. The snapshot is opt-in and does not change behaviour for callers that do not pass it.