apk: build the resolver name map without per-package allocations - #2466
Draft
markusthoemmes wants to merge 1 commit into
Draft
markusthoemmes wants to merge 1 commit into
markusthoemmes wants to merge 1 commit into
Conversation
Count entries per name first, carve every name's slice out of one backing array, and fill through per-name buckets so the map is never written during the fill. Package wrappers live in one slab. On the Wolfi x86_64 index a build drops from 236k allocations and 22.6 MB to under a thousand allocations and 18 MB. Build time is unchanged, the point is less garbage for the collector under memory pressure. Providers of a name are now appended in index order rather than map iteration order, which only affects tie-breaking and makes it deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count entries per name first, carve every name's slice out of one backing array, and fill through per-name buckets so the map is never written during the fill. Package wrappers live in one slab. On the Wolfi x86_64 index a build drops from 236k allocations and 22.6 MB to under a thousand allocations and 18 MB. Build time is unchanged, the point is less garbage for the collector under memory pressure. Providers of a name are now appended in index order rather than map iteration order, which only affects tie-breaking and makes it deterministic.