Skip to content

config: detect recursive includes - #2194

Open
officialasishkumar wants to merge 1 commit into
chainguard-dev:mainfrom
officialasishkumar:config-detect-include-cycles
Open

officialasishkumar wants to merge 1 commit into
chainguard-dev:mainfrom
officialasishkumar:config-detect-include-cycles

Conversation

@officialasishkumar

Copy link
Copy Markdown

Summary

  • track canonicalized config file paths while processing deprecated include chains
  • return a clear recursive include error instead of recursing indefinitely
  • add coverage for self-includes and two-file include cycles

Fixes #1627

Test plan

  • go test ./pkg/build/types
  • go test ./pkg/build/... ./internal/cli
  • go test ./...
  • git diff --check
  • go mod tidy && git diff --exit-code -- go.mod go.sum

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
@coreydaley-cg

Copy link
Copy Markdown
Contributor

The fix is right and everything is green except commit signing, which blocks the merge button. Can you sign the commit and force-push? If that's a hassle, say so and a maintainer can re-land it with you as co-author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apko include can loop forever by recursively included files.

2 participants