Skip to content

Update ResolvePackageNameVersionPin to handle invalid operators and update tests - #1642

Open
aryasoni98 wants to merge 2 commits into
chainguard-dev:mainfrom
aryasoni98:issue-1590
Open

aryasoni98 wants to merge 2 commits into
chainguard-dev:mainfrom
aryasoni98:issue-1590

Conversation

@aryasoni98

@aryasoni98 aryasoni98 commented Apr 26, 2025

Copy link
Copy Markdown

#1590 Update ResolvePackageNameVersionPin to handle invalid operators and update tests

@aryasoni98

Copy link
Copy Markdown
Author

@mbrancato I've raised the PR. Please review it, and if everything looks good, feel free to merge it.

Thanks!

@imjasonh
imjasonh requested review from Copilot and imjasonh and removed request for Copilot July 1, 2025 14:02
@mbrancato

Copy link
Copy Markdown

@aryasoni98 @imjasonh I do not have permissions to merge PRs in this repo.

@aryasoni98
aryasoni98 requested a review from imjasonh July 12, 2025 14:40
@aryasoni98

Copy link
Copy Markdown
Author

Hi @imjasonh , just a gentle follow-up on the PR when you get a chance.

If everything looks good, would appreciate it if you could proceed with the merge.
Thanks again for your time and guidance!

@aryasoni98

Copy link
Copy Markdown
Author

Hi @imjasonh, Just a quick follow-up on the PR. If it looks good, please merge.
Thanks!

@aryasoni98

Copy link
Copy Markdown
Author

Hi @imjasonh,
Just a friendly reminder about this PR whenever you get a moment. If everything looks good from your side, kindly proceed with the merge.

Thanks a lot for your time! 😊

@aryasoni98

Copy link
Copy Markdown
Author

@imjasonh @sergiodj @smoser Just a friendly reminder about this PR. If everything looks good, kindly review and merge it whenever you get a chance. Thanks!

@coreydaley-cg coreydaley-cg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning unrecognized operators into hard errors is the right instinct, but the live Wolfi aarch64 index has 69 == constraints (all libarrow==<version>), and == isn't in the operator switch. Today those resolve as "any version," which is its own bug; with this change, anything depending on libarrow fails to resolve. == needs handling as equality before this can land. Also worth knowing that #2467 replaces this parser wholesale, so coordinate with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants