Update ResolvePackageNameVersionPin to handle invalid operators and update tests - #1642
aryasoni98 wants to merge 2 commits into
Conversation
…pdate tests PR raise template commit
|
@mbrancato I've raised the PR. Please review it, and if everything looks good, feel free to merge it. Thanks! |
|
@aryasoni98 @imjasonh I do not have permissions to merge PRs in this repo. |
|
Hi @imjasonh , just a gentle follow-up on the PR when you get a chance. If everything looks good, would appreciate it if you could proceed with the merge. |
|
Hi @imjasonh, Just a quick follow-up on the PR. If it looks good, please merge. |
|
Hi @imjasonh, Thanks a lot for your time! 😊 |
coreydaley-cg
left a comment
There was a problem hiding this comment.
Turning unrecognized operators into hard errors is the right instinct, but the live Wolfi aarch64 index has 69 == constraints (all libarrow==<version>), and == isn't in the operator switch. Today those resolve as "any version," which is its own bug; with this change, anything depending on libarrow fails to resolve. == needs handling as equality before this can land. Also worth knowing that #2467 replaces this parser wholesale, so coordinate with that.
#1590 Update ResolvePackageNameVersionPin to handle invalid operators and update tests