[FIX] Use lowercase <windows.h> when cross-compiling via mingw#52
Open
AmmoniumX wants to merge 1 commit intocginternals:masterfrom
Open
[FIX] Use lowercase <windows.h> when cross-compiling via mingw#52AmmoniumX wants to merge 1 commit intocginternals:masterfrom
AmmoniumX wants to merge 1 commit intocginternals:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cross-compiling this project from linux to windows via mingw, it fails with this error:
This is because on linux, the path is case-sensitive and should be
#include <windows.h>The fix is simple, just change the include path to lowercase and it fixes it. This doesn't break windows since on windows they are case-insensitive anyways.
Replication steps:
Requirements:
mingw-w64packages on Arch Linux)Use a custom toolchain file to try compiling this on windows via mingw and observe the error, such as this:
Trying the same on this PR, the problem is fixed