Repository navigation
Feat/2027 edits - #5181
Open
lchen-2101 wants to merge 61 commits into
Open
Feat/2027 edits#5181lchen-2101 wants to merge 61 commits into
lchen-2101 wants to merge 61 commits into
Conversation
This was referenced Oct 9, 2026
Closed
Closed
Closed
Closed
Closed
Closed
kgudel
requested changes
Oct 20, 2026
| val units = config.getInt("edits.Q627.units") | ||
|
|
||
| override def apply(lar: LoanApplicationRegister): ValidationResult = | ||
| when(lar.property.totalUnits is greaterThanOrEqual(units)) { |
Contributor
There was a problem hiding this comment.
@chynnakeys the edit looks like it should be between $100,000 and $50,000,000 exclusive, should it be inclusive?
Contributor
Author
There was a problem hiding this comment.
verbiage is the same compared to previous years', only difference is the higher max limit; previous years' have been inclusive, so if we make this one exclusive, should we make previous years' exclusive as well?
Contributor
Author
|
will add the Q617 division by zero fix in here too. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combining all edits into one pr to avoid conflicts.